added support for multi-source input

[knassar]

this adds support for the multi-file concatenation features of the underlying wkhtmltopdf library, including cover-page and TOC generation, with options on a per-source basis.

Also, added a couple of basic tests while I was working on this.

[devongovett]

Cool, thanks for adding some tests too. We should see about possibly testing the generation of command line args more thoroughly as well, rather than actually generating a PDF every time. That will be faster.

[knassar]

That would be faster. Want me to make those changes to the tests?

[devongovett]

That would be great, thanks!

[knassar]

The two tests now just compare the generated CLI args against expected, instead of running the wkhtmltopdf bin. You'll need to do another npm install, as I added a dependency on rewire for tests in order to mock out the private execution code.

[zxlin]

@knassar Thanks for the contribution, can you refactor it and I'd be happy to pull it in.

[davesag]

👍 exactly what I need.

[chamnap]

When can it be merged? +1

[zxlin]

@chamnap: the repo's changed a lot since this PR was made, we'd need someone to refactor this before I can pull it.

[knassar]

Would love to get this merged, but I currently don’t have time to refactor the PR to match the repo. Will be happy to tackle it when I have a window, but not sure when that will be.

—Karim

On Jun 20, 2016, at 2:25 PM, Zhi Xiang Lin [email protected] wrote:

@chamnap https://github.com/chamnap: the repo's changed a lot since this PR was made, we'd need someone to refactor this before I can pull it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #53 (comment), or mute the thread https://github.com/notifications/unsubscribe/AATQm-HK_r6dMqwjkR1VVSgSQz_jByfSks5qNtsUgaJpZM4GOJ0p.

[DrMabuse23]

is it possible to use it with a blank string ?