Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue when the top level domain was trimmed #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix the issue when the top level domain was trimmed #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion artifactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2463,7 +2463,7 @@ def _get_all(self, lazy: bool, url=None, key="name", cls=None):
"return: A list of found objects
"""
if cls is Project:
request_url = self.drive.rstrip("/artifactory") + url
request_url = self.drive.replace("/artifactory", "") + url
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be something like rexegp? The replace doesn't care if it meats the string at the middle and we care only about the tail here

Suggested change
request_url = self.drive.replace("/artifactory", "") + url
request_url = re.sub(r"/artifactory$", "", self.drive) + url

else:
request_url = self.drive + url
response = self.session.get(request_url, auth=self.auth)
Expand Down
Loading