-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement Internet Identity example recommendations #1033
Open
krpeacock
wants to merge
4
commits into
master
Choose a base branch
from
kai/ii-example-recommendations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 51 additions & 38 deletions
89
motoko/internet_identity_integration/src/greet_frontend/src/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,61 @@ | ||
import {createActor, greet_backend} from "../../declarations/greet_backend"; | ||
import {AuthClient} from "@dfinity/auth-client" | ||
import {HttpAgent} from "@dfinity/agent"; | ||
import { createActor, greet_backend } from "../../declarations/greet_backend"; | ||
import { AuthClient } from "@dfinity/auth-client"; | ||
import { HttpAgent } from "@dfinity/agent"; | ||
|
||
let actor = greet_backend; | ||
// Global variables for convenience while you're becoming familiar with the interface. You should use local variables or closures in production | ||
window.greetActor; | ||
window.authClient; | ||
|
||
const greetButton = document.getElementById("greet"); | ||
greetButton.onclick = async (e) => { | ||
e.preventDefault(); | ||
const loginButton = document.getElementById("login"); | ||
|
||
greetButton.setAttribute("disabled", true); | ||
AuthClient.create().then((client) => { | ||
// Put this on the window so we can access it from the console. This is helpful for learning, but it's recommended to keep it in a closure in a real app. | ||
window.authClient = client; | ||
// We can use the authClient to check if the user is already authenticated | ||
setActor(client); | ||
|
||
// Now that the auth client is created, we can enable the login and greet buttons | ||
loginButton.removeAttribute("disabled"); | ||
greetButton.removeAttribute("disabled"); | ||
}); | ||
|
||
loginButton.onclick = () => { | ||
// start the login process and wait for it to finish | ||
window.authClient.login({ | ||
identityProvider: process.env.II_URL, | ||
onSuccess: () => { | ||
setActor(window.authClient); | ||
}, | ||
onError: (err) => { | ||
console.error(err); | ||
}, | ||
}); | ||
}; | ||
|
||
// Interact with backend actor, calling the greet method | ||
const greeting = await actor.greet(); | ||
greetButton.onclick = async () => { | ||
// Disable the button to prevent multiple clicks | ||
greetButton.setAttribute("disabled", true); | ||
|
||
greetButton.removeAttribute("disabled"); | ||
// Interact with backend actor, calling the greet method | ||
const greeting = await window.greetActor.greet(); | ||
|
||
document.getElementById("greeting").innerText = greeting; | ||
greetButton.removeAttribute("disabled"); | ||
|
||
return false; | ||
document.getElementById("greeting").innerText = greeting; | ||
}; | ||
|
||
const loginButton = document.getElementById("login"); | ||
loginButton.onclick = async (e) => { | ||
e.preventDefault(); | ||
|
||
// create an auth client | ||
let authClient = await AuthClient.create(); | ||
|
||
// start the login process and wait for it to finish | ||
await new Promise((resolve) => { | ||
authClient.login({ | ||
identityProvider: process.env.II_URL, | ||
onSuccess: resolve, | ||
}); | ||
}); | ||
|
||
// At this point we're authenticated, and we can get the identity from the auth client: | ||
const identity = authClient.getIdentity(); | ||
// Using the identity obtained from the auth client, we can create an agent to interact with the IC. | ||
const agent = new HttpAgent({identity}); | ||
// Using the interface description of our webapp, we create an actor that we use to call the service methods. | ||
actor = createActor(process.env.GREET_BACKEND_CANISTER_ID, { | ||
agent, | ||
}); | ||
|
||
return false; | ||
}; | ||
/** | ||
* Sets the actor to be used by the greet button | ||
* @param {AuthClient} an initialized AuthClient, which will have the identity of the user (logged in or not) | ||
*/ | ||
function setActor(authClient) { | ||
// At this point we're authenticated, and we can get the identity from the auth client: | ||
const identity = authClient.getIdentity(); | ||
// Using the identity obtained from the auth client, we can create an agent to interact with the IC. | ||
const agent = new HttpAgent({ identity }); | ||
// Using the interface description of our webapp, we create an actor that we use to call the service methods. | ||
krpeacock marked this conversation as resolved.
Show resolved
Hide resolved
|
||
window.greetActor = createActor(process.env.GREET_BACKEND_CANISTER_ID, { | ||
agent, | ||
}); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remove the login button onSuccess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I didn't notice that logic in the original version