Script to deploy nns-dapp in chunks #5527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
force-pushed
the
kloet/deploy-in-chunks
branch
from
6d66dae
to
6687761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When deploying nns-dapp to an application subnet, the WASM is too big.
To work around this, we deploy a WASM without assets and then upload the assets in separate chunks.
This is done in a GitHub workflow but it would be useful to do it locally for testing as well.
Changes
scripts/nns-dapp/split-assetsso it can work on Mac by usinggtarinstead oftar..github/workflows/deploy-to-app.yaml..github/workflows/deploy-to-app.yamlfrom the workflow.Tests
Tested manually on a local replica.
Todos
not necessary