Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imported ledger input update #5607

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Imported ledger input update #5607

merged 3 commits into from
Oct 11, 2024

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Oct 11, 2024 •
edited
Loading

Motivation

Despite being disabled, the ledger canister field is too prominent in the "Add Index Canister" modal.

Changes

  • Use the CanisterId component in the "Add Index Canister" modal.
  • Additionally, update the placeholder to avoid confusing users with the incorrect canister format.

Tests

  • Updated

Screenshots

image

image

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis marked this pull request as ready for review October 11, 2024 13:36
@mstrasinskis mstrasinskis requested a review from a team as a code owner October 11, 2024 13:36
dskloetd
dskloetd approved these changes Oct 11, 2024
View reviewed changes
frontend/src/lib/i18n/en.json Show resolved Hide resolved
@mstrasinskis mstrasinskis added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 6a79927 Oct 11, 2024
31 checks passed
@mstrasinskis mstrasinskis deleted the mstr/imported-ledger-input branch October 11, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @dskloetd