-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default feature flags as an object #5810
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
reviewed
Nov 21, 2024
yhabib
reviewed
Nov 21, 2024
dskloetd
approved these changes
Nov 21, 2024
yhabib
reviewed
Nov 21, 2024
yhabib
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an expected flag is not provided by
environment.featureFlags
, the missing value is taken from a string that is supposed to contain all default values. The issue is that this approach cannot be verified, and it already omits some values, which could lead to a broken app state when environment constants are missing or outdated.In cases where the
featureFlags
environment variable is empty or not provided, the dapp breaks with a dev console error:Uncaught (in promise) Error: Missing mandatory environment variables: featureFlags
This error is self-explanatory, so no changes are needed to handle this specific case.
However, when there are missing entries in the environment variable (e.g.,
record { 0="FEATURE_FLAGS"; 1="{}" };
), the dapp also breaks with the error:Error: derived() expects stores as input, got a falsy value.
This happens because no derived store is created for the missing value(s). While we could modify the store creation mechanism to always initialize with the
false
value, I believe having explicitly set default values is a better solution.Changes
defaultFeatureFlagValues: FeatureFlags<boolean>
.defaultFeatureFlagValues
.Tests
Todos
Not necessary.