Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3480: Refactors generateCsvFileToSave to manage datasets for more complex CSV files #5876

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Nov 28, 2024

Motivation

The report functionality for transactions requires more complex .csv structures, as shown in the screenshot. To achieve this, we need to introduce the concept of datasets, which are small tables within the file. All datasets will share the same headers.

Screenshot 2024-11-28 at 16 08 26

Changes

  • Refactors generateCsvFileToSave to handle datasets across multiple levels.
  • Introduces a new function, combineDatasetsToCsv, to merge multiple datasets into one.
  • Updates ExportNeuronsButton, the existing consumer of generateCsvFileToSave, to supply a dataset.

Tests

  • Added new tests for the updated API.
  • Refactored existing tests for the new API.

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib changed the title NNS1-3480: Refactors generateCsvFileToSave to handle datasets for more complex csv NNS1-3480: Refactors generateCsvFileToSave to manage datasets for more complex CSV files Nov 28, 2024
@yhabib yhabib marked this pull request as ready for review November 28, 2024 16:25
@yhabib yhabib requested a review from a team as a code owner November 28, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant