feat(station): serve metrics as properly certified HTTP asset #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keplervital
reviewed
Sep 6, 2024
| with_metrics_registry(SERVICE_NAME, |registry| { | ||
| registry | ||
| .gauge_mut( | ||
| "metrics_timestamp", |
There was a problem hiding this comment.
Alternatively the metrics registry could be adapted to use the prometheus format which optionally can include timestamp per each metric (check here)
There was a problem hiding this comment.
I don't see how this can be done with the Rust prometheus crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves station and control panel metrics as properly certified HTTP assets. The metrics include the timestamp at which they were exported. The metrics are refreshed and certified every time the metrics change, but they are not refreshed in a query call if only the canister cycles balance changes.
This PR also bumps dfinity/response-verification to
eefc99e2a0041ae46873864e6e2f7aa8506a361f.