Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SNS aggregator version to proposal-125509-agg #277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sa-github-api
Copy link
Collaborator

Motivation

A new version of the SNS aggregator is available. We would like to keep the snapshots up to date.

Changes

  • Updated the pinned default SNS aggregator version.

Tests

  • Please see CI.

@sa-github-api sa-github-api requested a review from a team as a code owner November 20, 2023 11:06
@lmuntaner
Copy link
Contributor

@bitdivine we should wait until after the release to be sure that it's the one in prod, right?

@bitdivine
Copy link
Member

bitdivine commented Nov 20, 2023

@lmuntaner If this is meant to be the one in prod (a perfectly reasonable suggestion) I would suggesting updating the bot to get the aggregator-prod tag by default and making a PR if the commit of that tag has changed. What do you think?

@bitdivine
Copy link
Member

Reminder to self: The release for current prod can be found with:

$ git ls-remote [email protected]:dfinity/nns-dapp.git | grep "$(git ls-remote [email protected]:dfinity/nns-dapp.git aggregator-prod | awk '{print $1}')" | grep -oE 'proposal-[0-9]+-agg'
proposal-125509-agg

@lmuntaner
Copy link
Contributor

@lmuntaner If this is meant to be the one in prod (a perfectly reasonable suggestion) I would suggesting updating the bot to get the aggregator-prod tag by default and making a PR if the commit of that tag has changed. What do you think?

Makes sense to me!

Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants