Bug fixes and tweaks for v3.4.0 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgasmith
commented
Jul 4, 2022
jcmgray
approved these changes
Jul 5, 2022
romanngg
pushed a commit
to romanngg/opt_einsum
that referenced
this pull request
Jul 6, 2022
* Unpins MyPy, now appears stable * Minor typing tweaks * Skips unicode surrogates, fixes dgasmith#182 * Adds simple validation to BranchBound, fixes dgasmith#136 * More accurate branch bound exception handler * Update opt_einsum/paths.py
dgasmith
added a commit
that referenced
this pull request
Jul 9, 2022
…195) * Fix `dp` to work for contractions with no sized axes (scalars only). * Add comma for linter * Bug fixes and tweaks for v3.4.0 (#192) * Unpins MyPy, now appears stable * Minor typing tweaks * Skips unicode surrogates, fixes #182 * Adds simple validation to BranchBound, fixes #136 * More accurate branch bound exception handler * Update opt_einsum/paths.py Co-authored-by: Daniel Smith <[email protected]>
|
Hey @dgasmith! curious if there's any timeline for releasing 3.4.0 yet? |
|
I'm also wondering about a v3.4.0 release (including for conda-forge/staged-recipes#22451). Let me know if there is something I can help with? |
|
Let's work on current PRs a bit, my main concern is that typing may be annoying for downstream users. No blockers beyond that at the moment beyond a little time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few final bug fixes for v3.4.0.
The current changes compared to v3.3.0 mostly fall into the following categories:
Generally we wait until some feature; however, It has been some time since we have had a release and the bug fixes are QoL improvements. See #191 for v3.5.0+ plans.
Status