[@dhealthdapps/backend] fix(routes): remove query param for revoke en…

…dpoint
dhealthproject · Jan 13, 2023 · 0a243ea · 0a243ea
1 parent 712ec1a
commit 0a243ea
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/runtime/backend/src/oauth/routes/OAuthController.ts b/runtime/backend/src/oauth/routes/OAuthController.ts
@@ -230,7 +230,6 @@ export class OAuthController {
   protected async revoke(
     @NestRequest() req: Request,
     @Param("provider") provider: string,
-    @Query() query: OAuthCallbackRequest,
   ) {
     // read and decode access token, then find account in database
     const account: AccountDocument = await this.authService.getAccount(req);

diff --git a/runtime/backend/src/oauth/services/OAuthService.ts b/runtime/backend/src/oauth/services/OAuthService.ts
@@ -210,7 +210,7 @@ export class OAuthService {
     }
     // if scope not contains read_all - throw an exception
     if (request && request.scope !== this.expectedScope) {
-      throw new HttpException(`Unauthorized`, 401);
+      throw new HttpException(`Forbidden`, 403);
     }
 
     // reads OAuth provider from configuration

diff --git a/runtime/backend/tests/unit/oauth/routes/OAuthController.spec.ts b/runtime/backend/tests/unit/oauth/routes/OAuthController.spec.ts
@@ -194,9 +194,11 @@ describe("common/OAuthController", () => {
         .mockRejectedValue(expectedError);
 
       // act
-      const result = (controller as any).callback(jest.fn(), "testProvider", {
-        scope: "read,activity:read_all",
-      });
+      const result = (controller as any).callback(
+        jest.fn(),
+        "testProvider",
+        jest.fn(),
+      );
 
       // assert
       expect(result).rejects.toThrowError(expectedError);