[@dhealthdapps/backend] refactor(notifier): remove DappHelper depende…

…ncy in AlertNotifier
dhealthproject · Jan 13, 2023 · d0eed7a · d0eed7a
1 parent 3ae6466
commit d0eed7a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/runtime/backend/src/notifier/listeners/AlertNotifier.ts b/runtime/backend/src/notifier/listeners/AlertNotifier.ts
@@ -19,7 +19,6 @@ import { NotifierFactory } from "../concerns/NotifierFactory";
 import { AlertsConfig } from "../../common/models/MonitoringConfig";
 import { Notifier } from "../models/Notifier";
 import { NotifierType } from "../models/NotifierType";
-import { DappHelper } from "../../common/concerns/DappHelper";
 import { LogService } from "../../common/services/LogService";
 
 /**
@@ -71,12 +70,10 @@ export class AlertNotifier {
    *
    * @param {ConfigService}   configService
    * @param {NotifierFactory} notifierFactory
-   * @param {DappHelper}      dappHelper
    */
   constructor(
     private readonly configService: ConfigService,
     private readonly notifierFactory: NotifierFactory,
-    private readonly dappHelper: DappHelper,
   ) {
     // get config
     this.alertsConfig = this.configService.get<AlertsConfig>("alerts");

diff --git a/runtime/backend/tests/unit/notifier/listeners/AlertNotifier.spec.ts b/runtime/backend/tests/unit/notifier/listeners/AlertNotifier.spec.ts
@@ -38,7 +38,6 @@ describe("notifier/AlertNotifier", () => {
       providers: [
         AlertNotifier,
         EventEmitter2, // requirement from AlertNotifier
-        DappHelper, // requirement from AlertNotifier
         NotifierFactory, // requirement from AlertNotifier
         EmailNotifier, // requirement from AlertNotifier
         NetworkService, // requirement from DappHelper
@@ -71,7 +70,6 @@ describe("notifier/AlertNotifier", () => {
     service = module.get<AlertNotifier>(AlertNotifier);
     configService = module.get<ConfigService>(ConfigService);
     notifierFactory = module.get<NotifierFactory>(NotifierFactory);
-    dappHelper = module.get<DappHelper>(DappHelper);
   });
 
   it("should be defined", () => {
@@ -91,9 +89,6 @@ describe("notifier/AlertNotifier", () => {
       const notifierSendInternalCall = jest
         .spyOn(notifier, "sendInternal")
         .mockResolvedValue();
-      const dappHelperCreateDetailsTableHTMLCall = jest
-        .spyOn(dappHelper, "createDetailsTableHTML")
-        .mockReturnValue("test-html-content");
       const alertEvent: AlertEvent = AlertEvent.create(
         new Date(),
         "warn",
@@ -108,7 +103,6 @@ describe("notifier/AlertNotifier", () => {
 
       // assert
       expect(configServiceGetCall).toHaveBeenCalledTimes(0);
-      expect(dappHelperCreateDetailsTableHTMLCall).toHaveBeenCalledTimes(0);
       expect(notifierSendInternalCall).toHaveBeenCalledTimes(0);
     });