Localization support (Issue #54) #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linked to issue dheid#54
|
Hi @Nilon123456789! Thank you very much for your contribution!!! I don't know why, but I must have overseen your pull request. Will look into it now. |
|
LGTM! Thank you very much for your contribution! Merci bien! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for issue #54.
I added in the constructor of the different required class the field
localeto be able to reference the localization to use.I haven't made unit test for my implementation, since I don't know if there is a correct way of testing localization. However, I created two example files allowing a user to quickly test the localization. (
ColorPickerDialogLocalizedDemo.java&ColorPickerLocalizedExample.java)