fix: [DHIS2-17324] Ensure standard report id is in the right format

[JoakimSM]

No description provided.

[dhis2-bot]

🚀 Deployed on https://pr-393--dhis2-reports.netlify.app

[tomzemp]

Thanks for the PR 🙏. Looks good to me!

One thing I noticed: the ticket says that the GET request could currently be sent to /arbitrary/same-origin/path/data.html, but the app seems to fire a request to reports/arbitrary/same-origin/path/data.html :

reports-app/src/utils/api.js

Line 447 in 940f8af

api.get(`reports/${id}/data.html`, {

.

I think it's good to have this check client-side, but I would also have expected the backend to do some sanitization of the request and check that it the "id" in reports/${id}/data.html was valid?

[JoakimSM]

Thanks for the PR 🙏. Looks good to me!

One thing I noticed: the ticket says that the GET request could currently be sent to /arbitrary/same-origin/path/data.html, but the app seems to fire a request to reports/arbitrary/same-origin/path/data.html :

reports-app/src/utils/api.js

Line 447 in 940f8af

api.get(`reports/${id}/data.html`, {

.
I think it's good to have this check client-side, but I would also have expected the backend to do some sanitization of the request and check that it the "id" in reports/${id}/data.html was valid?

We talked it through on slack.

[linadhis2]

LGTM from QA perspective

[dhis2-bot]

🎉 This PR is included in version 100.0.60 🎉

The release is available on:

• AppHub release
• GitHub release

Your semantic-release bot 📦🚀