Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime Re-Org - Relay, Appchain & Standalone #500

Closed
wants to merge 30 commits into from
Closed

Runtime Re-Org - Relay, Appchain & Standalone #500

wants to merge 30 commits into from

Conversation

smohan-dw
Copy link
Member

@smohan-dw smohan-dw commented Aug 11, 2024 •
edited
Loading

ReOrg Details

New Runtimes

  • CORD Loom - Relaychain using Polkadot relay protocol
  • CORD Weave - Appchain using Substrate and Cumulus

Changes to Standalone Runtime

  • Standalone renamed to CORD Braid
  • Supports two runtimes
    • Braid Base - Standalone without Governance
    • Braid Plus - Standalone with Governance
  • Removed network membership requirement as the accounts are now using core units
  • Had to rename Statement pallet to DId-Token due to upstream conflict (todo - need to finalise the pallet name)

@amarts
Copy link
Member

amarts commented Aug 11, 2024

Just had a glance. 340 files changed, and may take some time to review. I will block sometime tomorrow for this.

about CI, would prefer to offload some work on this.

  • Is the rustfmt version you are having, and the one in CI different? should we update CI?
  • build is good, clippy will check tomorrow.

Can we do a discussion on this during community meeting?

@smohan-dw
Copy link
Member Author

Just had a glance. 340 files changed, and may take some time to review. I will block sometime tomorrow for this.

about CI, would prefer to offload some work on this.

  • Is the rustfmt version you are having, and the one in CI different? should we update CI?
  • build is good, clippy will check tomorrow.

will check that before removing the draft status

Can we do a discussion on this during community meeting?

good idea. we can do that.

amarts
amarts previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@amarts amarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some conflicts. Will pick it up as a follow-up.

This was referenced Sep 20, 2024
Merged
Open
@vatsa287 vatsa287 mentioned this pull request Sep 26, 2024
Merged
@smohan-dw smohan-dw marked this pull request as ready for review September 28, 2024 04:40
@smohan-dw smohan-dw closed this by deleting the head repository Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarts amarts amarts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@smohan-dw @amarts @vidyaa01 @zeel991 @vatsa287 @JiyaGupta-cs @mrswastik-robot