-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dedir: Add new pallet for Decentralised Directories
with blob
#502
Conversation
Signed-off-by: Shreevatsa N <[email protected]>
Signed-off-by: Shreevatsa N <[email protected]>
Signed-off-by: Shreevatsa N <[email protected]>
9e00e34
to
7427018
Compare
Signed-off-by: Shreevatsa N <[email protected]>
7427018
to
aa242e5
Compare
Signed-off-by: Shreevatsa N <[email protected]>
pallets/dedir/src/types.rs
Outdated
/// - `OWNER`: The creator or owner of the registry. This permission level encompasses the full | ||
/// range of management capabilities, including the permissions of both `DELEGATE` and `ADMIN`. | ||
#[derive(Encode, Decode, MaxEncodedLen, Clone, RuntimeDebug, PartialEq, Eq, TypeInfo)] | ||
pub enum Permissions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permission as Enums will not help to create composite permissions. A delegate can have multiple roles associated with a registry. Please refer the chain-space permissioning system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack,
Have updated the flow to use bitwise and handle composite permissions.
use sp_std::prelude::*; | ||
|
||
#[derive(Encode, Decode, MaxEncodedLen, Clone, RuntimeDebug, PartialEq, Eq, TypeInfo)] | ||
pub enum RegistrySupportedStateOf { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a DRAFT state at the chain level? Without that this can be a bool filed representing the status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This thought process came when we asked the question if chain alone is used as 'store' also, how to differentiate between something which is not ready to be 'lookedup' (or queried), and the one record which is ready to do the lookup.
Having these states covers most of the usecases is what we thought.
fb0e4df
to
2f35581
Compare
Signed-off-by: Shreevatsa N <[email protected]>
2f35581
to
caddd0b
Compare
Signed-off-by: Shreevatsa N <[email protected]>
done with #504 |
Updates: #503
Abandoned. Do not merge.