Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedir: Add new pallet for Decentralised Directories with blob #502

Closed
wants to merge 7 commits into from

Conversation

vatsa287
Copy link
Member

@vatsa287 vatsa287 commented Aug 23, 2024

Updates: #503

Abandoned. Do not merge.

Signed-off-by: Shreevatsa N <[email protected]>
/// - `OWNER`: The creator or owner of the registry. This permission level encompasses the full
/// range of management capabilities, including the permissions of both `DELEGATE` and `ADMIN`.
#[derive(Encode, Decode, MaxEncodedLen, Clone, RuntimeDebug, PartialEq, Eq, TypeInfo)]
pub enum Permissions {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permission as Enums will not help to create composite permissions. A delegate can have multiple roles associated with a registry. Please refer the chain-space permissioning system.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack,
Have updated the flow to use bitwise and handle composite permissions.

use sp_std::prelude::*;

#[derive(Encode, Decode, MaxEncodedLen, Clone, RuntimeDebug, PartialEq, Eq, TypeInfo)]
pub enum RegistrySupportedStateOf {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a DRAFT state at the chain level? Without that this can be a bool filed representing the status

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thought process came when we asked the question if chain alone is used as 'store' also, how to differentiate between something which is not ready to be 'lookedup' (or queried), and the one record which is ready to do the lookup.

Having these states covers most of the usecases is what we thought.

@vatsa287 vatsa287 force-pushed the registry-blob-1 branch 2 times, most recently from fb0e4df to 2f35581 Compare August 26, 2024 17:21
Signed-off-by: Shreevatsa N <[email protected]>
@vatsa287 vatsa287 marked this pull request as draft September 19, 2024 10:07
@amarts
Copy link
Member

amarts commented Oct 28, 2024

done with #504

@amarts amarts closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants