Implement MembershipNotFound Error Handling #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsa287
requested changes
Sep 26, 2024
| run_to_block(1); | ||
|
|
||
| // Check if a non-existent account is a member | ||
| assert!(!NetworkMembership::is_member(&AccountId::new([99u8; 32]))); |
There was a problem hiding this comment.
Use assert_err to keep consistency, and can check which error code.
|
|
||
| // Check that a non-existent account cannot expire | ||
| run_to_block(10); // Advance time beyond the expiration period | ||
| assert!(!NetworkMembership::is_member(&AccountId::new([99u8; 32]))); // Should still be false |
|
@vatsa287 I have made the changes |
|
@vatsa287 Please review |
|
@vatsa287 can you pls review this |
Signed-off-by: Shreevatsa N <[email protected]>
vatsa287
force-pushed
the
MembershipNotFound
branch
from
c663181
to
e00c8f1
Compare
|
The tests were not running for this PR for some reason, I had to checkout, rebase & force-push for it to run. Errors are below. |
amarts
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291
Description
This PR enhances the membership management functionality in the pallet-network-membership by introducing tests that validate the behavior of the system when interacting with non-existent memberships. The following tests have been added:
Test for Revoking Non-Existent Membership:
Implemented the
test_revoke_membership_non_existentto ensure that attempting to revoke a membership for an account that does not exist correctly raises the MembershipNotFound error.This test checks that the member count remains unchanged when the revoke operation is attempted on a non-existent account.
Test for Checking Non-Existent Membership:
Added
test_check_membership_non_existentto verify that the system correctly identifies a non-existent account as not being a member. This ensures the integrity of the membership verification process.Test for Auto Expiration of Non-Existent Membership:
Included
test_auto_expire_non_existent_membershipto confirm that a non-existent account does not trigger any expiration logic. This test advances the block number to simulate the passage of time and checks that the account remains non-existent.Testing
Tested using
cargo test -p pallet-network-membership testScreenshots