Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate schema-accounts with registries & entries #516

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Integrate schema-accounts with registries & entries #516

merged 3 commits into from
Oct 21, 2024

Conversation

vatsa287
Copy link
Member

@vatsa287 vatsa287 commented Oct 18, 2024 •
edited
Loading

This PR,

  • Integrates the account based schema-management pallet schema-accounts into registries & entries.
  • Updates the runtime spec to 9400 or cord package to 0.9.4.

@vatsa287 vatsa287 marked this pull request as draft October 18, 2024 18:39
@vatsa287 vatsa287 force-pushed the integrate-schema-with-registries-3 branch from 6e0d9b9 to a6d1f5c Compare October 19, 2024 06:09
vatsa287
vatsa287 commented Oct 19, 2024
View reviewed changes
pallets/registries/src/lib.rs
@@ -607,6 +609,7 @@ pub mod pallet {
revoked: false,
archived: false,
digest,
schema_id,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amarts Here do you see the need of storing the schema_id with the registry is associated with?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It would be good to store.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@vatsa287 vatsa287 marked this pull request as ready for review October 21, 2024 07:19
@vatsa287 vatsa287 requested a review from amarts October 21, 2024 07:19
@amarts amarts merged commit 75568ed into dhiway:develop Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarts amarts amarts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vatsa287 @amarts