Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statement: Disallow delegate-2 to revoke/update delegate-1's statement #524

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vatsa287
Copy link
Member

<Demo PR>, <Do Not Merge>

Example:

  1. Creator creates a chainspace.
  2. Adds a delegate delegate-1 with ASSERT permission.
  3. Adds a delegate delegate-2 with ASSERT permission.
  4. Create a statement statement-1 from delegate-1.
  5. Create a statement statement-2 from delegate-2.
  6. Try revoking/edit statement-1 from delegate-2 or vice versa. ( Should this be allowed, currently this followed in DeDir too).

@vatsa287 vatsa287 marked this pull request as draft November 13, 2024 07:31
@vatsa287
Copy link
Member Author

@smohan-dw @amarts
I needed your insights on above.

If this should be allowed we can something like below in entries/ statement.

  1. Check if the origin has a admin authorisation of the chainspace/ registry.
  2. Check if the origin is the creator, creator is stored during creation of the statement/ entry.
  3. Allow only if any one of above is true, disallow else.

@smohan-dw
Copy link
Member

The delegates should be able to do any operations on the entries posted by other delegates. Only the registry admins should have that capability. Also make sure we are checking for a delegate permissions for revoke operation. Not all delegates have this permission. Go ahead and make the changes needed for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants