Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port search provider to Gio.Application and Gio provided DBus bindings #359

Conversation

camelCaseNick
Copy link
Contributor

This lets Gio manage the main loop, and thus we can make use of its features such as inactivity-timeout, while simultaneously removing the dependency on the additional DBus bindings.

fixes #329

Copy link
Member

@rafaelmardojai rafaelmardojai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good overall. We also wanted to unify the provider with the main app in the future, so this is a step in the right direction.

Thanks for taking the time to work on this!

dialect/search_provider/search_provider.in Outdated Show resolved Hide resolved
This lets Gio manage the main loop, and thus we can make
use of its features such as inactivity-timeout, while
simultaneously removing the dependency on the additional
DBus bindings.

fixes dialect-app#329

Signed-off-by: Markus Göllnitz <[email protected]>
@camelCaseNick camelCaseNick force-pushed the camelCaseNick/search-provider-application branch from 33f61e1 to ec98dc1 Compare December 1, 2023 21:08
@mufeedali mufeedali merged commit 8f050bc into dialect-app:main Dec 5, 2023
2 checks passed
@mufeedali
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always running in the background
3 participants