Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create custom TextView widget #363

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Create custom TextView widget #363

merged 3 commits into from
Dec 11, 2023

Conversation

rafaelmardojai
Copy link
Member

Follow up of #355.

  • Create a custom TextView widget to implement our needs
  • Implement scroll controlled font size

@rafaelmardojai
Create custom TextView widget
f88ba0d 
- Create a custom TextView widget to implement our needs
- Implement scroll controlled font size
@rafaelmardojai
Update NEWS
6061277
mufeedali
mufeedali approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@mufeedali mufeedali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug where changing the size of one view would not change the other one, I found that we werent using a bidirectional bind. I've fixed that now and I'm happy with the code and the functionality, so we should be good.

@mufeedali mufeedali merged commit c79a6c4 into main Dec 11, 2023
2 checks passed
@mufeedali mufeedali deleted the textview-widget branch December 11, 2023 15:04
@rafaelmardojai
Copy link
Member Author

There was a bug where changing the size of one view would not change the other one, I found that we werent using a bidirectional bind. I've fixed that now and I'm happy with the code and the functionality, so we should be good.

Ohh true, I totally forgot to add binding flags at all 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mufeedali mufeedali mufeedali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelmardojai @mufeedali