Split more things into libraries #7554
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not fully address the issue of most everything being a giant library but it's a start. I got here by trying to isolate `path.cpp` into its own library and quickly realized that it transitively depends on everything. This is the point where I got to with splitting things up (and gave up for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fully address the issue of most everything being a giant library but it's a start.
I got here by trying to isolate
path.cppinto its own library and quickly realized that it transitivelydepends on everything.
This is the point where I got to with splitting things up (and gave up for now).
Most of the diff count is from moving SFX enums into a separate file (so that code that only needs the IDs can avoid depending on the entire sound subsystem).