Do not apply item validation to Single Player games #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7506 introduced calls to item validation into
Player::CanUseItem()andCalcSelfItems()which are functions shared between Single Player and Multiplayer games. The item validation should probably not be applied to Single Player at all because data errors introduced by bugs in vanilla can make their way into DevilutionX via the item data stored in Single Player savegames. Those data errors can cause items to appear invalid when they actually aren't.Note that the steps to reproduce described in #7561 will no longer work after incorporating this fix.