Divorce town seed from game seed #7563
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
approved these changes
Nov 27, 2024
|
I thought syncing shops was a feature :D |
|
I guess it could be made into a feature. Might be worth implementing an option for Lua or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7030 removed the logic that combines the town seed with
SDL_GetTicks()because theGenerateSeed()function that uses the xoshiro generator was applied to town seed rotation inSaveLevel()andDeltaLeaveSync(). However, the initial town seed is still dependent on the game seed, meaning players who join the same Multiplayer game session will have the same initial set of shops. This PR further applies the xoshiro generator to the initial town seed to fix that blind spot.