Remove @NotNull annotation

dice-group · Nov 13, 2023 · 34f6ff2 · 34f6ff2
1 parent cd86f42
commit 34f6ff2
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 14 deletions.
diff --git a/docs/develop/extend-metrics.md b/docs/develop/extend-metrics.md
@@ -46,7 +46,6 @@ The following gives you an examples on how to work with the `data` parameter:
     }
 
     @Override
-    @Nonnull
     public Model createMetricModel(StresstestMetadata task, Map<String, List<QueryExecutionStats>> data) {
         for (String queryID : task.queryIDS()) {
             // This list contains every query execution statistics of one query from

diff --git a/pom.xml b/pom.xml
@@ -176,11 +176,6 @@
             <artifactId>spring-context</artifactId>
             <version>6.0.11</version>
         </dependency>
-        <dependency>
-            <groupId>javax.validation</groupId>
-            <artifactId>validation-api</artifactId>
-            <version>2.0.1.Final</version>
-        </dependency>
     </dependencies>
 
 

diff --git a/src/main/java/org/aksw/iguana/cc/metrics/ModelWritingMetric.java b/src/main/java/org/aksw/iguana/cc/metrics/ModelWritingMetric.java
@@ -5,16 +5,15 @@
 import org.apache.jena.rdf.model.Model;
 import org.apache.jena.rdf.model.ModelFactory;
 
-import javax.validation.constraints.NotNull;
 import java.util.List;
 import java.util.Map;
 
 public interface ModelWritingMetric {
-    default @NotNull Model createMetricModel(List<HttpWorker> workers, List<HttpWorker.ExecutionStats>[][] data, IRES.Factory iresFactory) {
+    default Model createMetricModel(List<HttpWorker> workers, List<HttpWorker.ExecutionStats>[][] data, IRES.Factory iresFactory) {
         return ModelFactory.createDefaultModel();
     }
 
-    default @NotNull Model createMetricModel(List<HttpWorker> workers, Map<String, List<HttpWorker.ExecutionStats>> data, IRES.Factory iresFactory) {
+    default Model createMetricModel(List<HttpWorker> workers, Map<String, List<HttpWorker.ExecutionStats>> data, IRES.Factory iresFactory) {
         return ModelFactory.createDefaultModel();
     }
 }
diff --git a/src/main/java/org/aksw/iguana/cc/metrics/impl/AggregatedExecutionStatistics.java b/src/main/java/org/aksw/iguana/cc/metrics/impl/AggregatedExecutionStatistics.java
@@ -12,7 +12,6 @@
 import org.apache.jena.rdf.model.ResourceFactory;
 import org.apache.jena.vocabulary.RDF;
 
-import javax.validation.constraints.NotNull;
 import java.math.BigInteger;
 import java.time.Duration;
 import java.util.List;
@@ -28,7 +27,6 @@ public AggregatedExecutionStatistics() {
     }
 
     @Override
-    @NotNull
     public Model createMetricModel(List<HttpWorker> workers, List<HttpWorker.ExecutionStats>[][] data, IRES.Factory iresFactory) {
         Model m = ModelFactory.createDefaultModel();
         for (var worker : workers) {
@@ -41,7 +39,6 @@ public Model createMetricModel(List<HttpWorker> workers, List<HttpWorker.Executi
     }
 
     @Override
-    @NotNull
     public Model createMetricModel(List<HttpWorker> workers, Map<String, List<HttpWorker.ExecutionStats>> data, IRES.Factory iresFactory) {
         Model m = ModelFactory.createDefaultModel();
         for (String queryID : data.keySet()) {

diff --git a/src/main/java/org/aksw/iguana/cc/metrics/impl/EachExecutionStatistic.java b/src/main/java/org/aksw/iguana/cc/metrics/impl/EachExecutionStatistic.java
@@ -11,7 +11,6 @@
 import org.apache.jena.rdf.model.Resource;
 import org.apache.jena.rdf.model.ResourceFactory;
 
-import javax.validation.constraints.NotNull;
 import java.math.BigInteger;
 import java.util.List;
 
@@ -22,7 +21,6 @@ public EachExecutionStatistic() {
     }
 
     @Override
-    @NotNull
     public Model createMetricModel(List<HttpWorker> workers, List<HttpWorker.ExecutionStats>[][] data, IRES.Factory iresFactory) {
         Model m = ModelFactory.createDefaultModel();
         for (var worker : workers) {