Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Ontology IRI #269

Merged
merged 25 commits into from
Oct 1, 2024
Merged

Change Ontology IRI #269

merged 25 commits into from
Oct 1, 2024

Conversation

nck-mlcnv
Copy link
Contributor

@nck-mlcnv nck-mlcnv commented Aug 19, 2024 •
edited
Loading

Also does:

  • removes unused test files
  • add file upload of the ontology to the ftp server

@nck-mlcnv nck-mlcnv self-assigned this Aug 19, 2024
@nck-mlcnv nck-mlcnv linked an issue Aug 19, 2024 that may be closed by this pull request
Make ontology accessible online #255
Closed
@nck-mlcnv nck-mlcnv requested a review from bigerl September 2, 2024 11:41
bigerl
bigerl requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. This seems not fully completed yet.

  1. Is the distribution at that path clarified? A action that publishes the file on release would be good.
    2.Three are still quite some occurrences of iguana-benchmark.eu left:
    image

@nck-mlcnv
Copy link
Contributor Author

The test files are all not used actually, I will remove them soon

@bigerl
Copy link
Member

bigerl commented Sep 6, 2024

I think the files should then be removed in this PR so that we don't have to change them.

@nck-mlcnv nck-mlcnv requested a review from bigerl September 20, 2024 10:41
bigerl
bigerl approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look now good to me.

@nck-mlcnv nck-mlcnv merged commit a465547 into develop Oct 1, 2024
3 checks passed
@nck-mlcnv nck-mlcnv deleted the feature/ontology-link branch October 1, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigerl bigerl bigerl approved these changes

Assignees

@nck-mlcnv nck-mlcnv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ontology accessible online
2 participants
@nck-mlcnv @bigerl