Fixed a problem in the sanity check of counts.

dice-group · Sep 29, 2024 · 3e6ef41 · 3e6ef41
1 parent caa5adf
commit 3e6ef41
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/org/dice_research/cel/PruneCEL.java b/src/main/java/org/dice_research/cel/PruneCEL.java
@@ -279,7 +279,8 @@ public static void main(String[] args) throws Exception {
             // XXX Choose the learning problem (as JSON file)
             JSONLearningProblemReader reader = new JSONLearningProblemReader();
 //            Collection<LearningProblem> problems = reader.readProblems("LPs/Family/lps.json");
-            Collection<LearningProblem> problems = reader.readProblems("/home/micha/Downloads/TandF_MST5_reverse.json");
+            //Collection<LearningProblem> problems = reader.readProblems("/home/micha/Downloads/TandF_MST5_reverse.json");
+            Collection<LearningProblem> problems = reader.readProblems("/home/micha/Downloads/TandF_MST5.json");
             // Collection<LearningProblem> problems =
             // reader.readProblems("LPs/QA/TandF_MST5_reverse.json");
 

diff --git a/src/main/java/org/dice_research/cel/refine/SuggestorBasedRefinementOperator.java b/src/main/java/org/dice_research/cel/refine/SuggestorBasedRefinementOperator.java
@@ -197,7 +197,7 @@ protected void addResult(ScoredIRI suggestion, ClassExpression newNode, boolean
         protected void addResult(ClassExpression newExpression, SelectionScores scores, boolean addedEdge) {
             // Check results for sanity
             if ((scores.getPosCount() < 0) || (scores.getPosCount() > numberOfPositives) || (scores.getNegCount() < 0)
-                    || (scores.getPosCount() > numberOfNegatives)) {
+                    || (scores.getNegCount() > numberOfNegatives)) {
                 LOGGER.error("Got wrong counts: #positives={}, #negatives={}, expression={}, scores={}",
                         numberOfPositives, numberOfNegatives, newExpression, scores);
             }

diff --git a/src/main/java/org/dice_research/cel/refine/suggest/sparql/SparqlBasedSuggestor.java b/src/main/java/org/dice_research/cel/refine/suggest/sparql/SparqlBasedSuggestor.java
@@ -79,7 +79,7 @@ protected Collection<ScoredIRI> performQuery(SuggestionData data, Collection<Str
             }
             data.addBaseScore(scoredIris);
             Optional<ScoredIRI> faultyResult = scoredIris.stream().filter(
-                    s -> s.posCount < 0 || s.posCount > data.maxPos || s.negCount < 0 || s.posCount > data.maxNeg)
+                    s -> s.posCount < 0 || s.posCount > data.maxPos || s.negCount < 0 || s.negCount > data.maxNeg)
                     .findFirst();
             if (faultyResult.isPresent()) {
                 LOGGER.error("Got a faulty count: #positives={}, #negatives={}, scoredIRI={}", data.maxPos, data.maxNeg,