feat: small pdfkit unifications + disable linting it (#2614)

.eslintignore

@@ -1,5 +1,6 @@
 .gitignore
 node_modules
 lib
+dist
 rollup.config.js
-packages/yoga/dist
+packages/pdfkit

.prettierignore

@@ -1,2 +1,3 @@
 yoga-layout
 lib
+packages/pdfkit

packages/pdfkit/src/data.js

@@ -44,8 +44,9 @@ class Data {
     const int = this.readUInt32();
     if (int >= 0x80000000) {
       return int - 0x100000000;
+    } else {
+      return int;
     }
-    return int;
   }
 
   writeInt32(val) {
@@ -70,8 +71,9 @@ class Data {
     const int = this.readUInt16();
     if (int >= 0x8000) {
       return int - 0x10000;
+    } else {
+      return int;
     }
-    return int;
   }
 
   writeInt16(val) {

packages/pdfkit/src/image.js

@@ -28,11 +28,11 @@ class PDFImage {
 
     if (data[0] === 0xff && data[1] === 0xd8) {
       return new JPEG(data, label);
-    }
-    if (data[0] === 0x89 && data.toString('ascii', 1, 4) === 'PNG') {
+    } else if (data[0] === 0x89 && data.toString('ascii', 1, 4) === 'PNG') {
       return new PNG(data, label);
+    } else {
+      throw new Error('Unknown image format.');
     }
-    throw new Error('Unknown image format.');
   }
 }
 

packages/pdfkit/src/image/jpeg.js

@@ -54,7 +54,7 @@ class JPEG {
     // min and max values from the default, we invert the colors. See
     // section 4.8.4 of the spec.
     if (this.colorSpace === 'DeviceCMYK') {
-      this.obj.data.Decode = [1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0];
+      this.obj.data['Decode'] = [1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0];
     }
 
     this.obj.end(this.data);

packages/pdfkit/src/mixins/color.js

@@ -48,8 +48,7 @@ export default {
       color.apply(stroke);
       return true;
       // see if tiling pattern, decode & apply it it
-    }
-    if (Array.isArray(color) && color[0] instanceof PDFTilingPattern) {
+    } else if (Array.isArray(color) && color[0] instanceof PDFTilingPattern) {
       color[0].apply(stroke, color[1]);
       return true;
     }
@@ -118,8 +117,7 @@ export default {
   },
 
   _doOpacity(fillOpacity, strokeOpacity) {
-    let dictionary;
-    let name;
+    let dictionary, name;
     if (fillOpacity == null && strokeOpacity == null) {
       return;
     }

packages/pdfkit/src/mixins/metadata.js

@@ -12,9 +12,7 @@ export default {
   _addInfo() {
     this.appendXML(`
         <rdf:Description rdf:about="" xmlns:xmp="http://ns.adobe.com/xap/1.0/">
-            <xmp:CreateDate>${
-              this.info.CreationDate.toISOString().split('.')[0] + 'Z'
-            }</xmp:CreateDate>
+            <xmp:CreateDate>${this.info.CreationDate.toISOString().split('.')[0] + 'Z'}</xmp:CreateDate>
             <xmp:CreatorTool>${this.info.Creator}</xmp:CreatorTool>
         </rdf:Description>
         `);
@@ -88,7 +86,7 @@ export default {
         Metadata was introduced in PDF 1.4, so adding it to 1.3
         will likely only take up more space.
         */
-    if (this.version !== 1.3) {
+    if (this.version != 1.3) {
       this.metadataRef = this.ref({
         length: this.metadata.getLength(),
         Type: 'Metadata',

packages/pdfkit/src/mixins/vector.js

@@ -289,6 +289,17 @@ export default {
 
   transform(m11, m12, m21, m22, dx, dy) {
     // keep track of the current transformation matrix
+    if (
+      m11 === 1 &&
+      m12 === 0 &&
+      m21 === 0 &&
+      m22 === 1 &&
+      dx === 0 &&
+      dy === 0
+    ) {
+      // Ignore identity transforms
+      return this;
+    }
     const m = this._ctm;
     const [m0, m1, m2, m3, m4, m5] = m;
     m[0] = m0 * m11 + m2 * m12;

packages/pdfkit/src/outline.js

@@ -5,15 +5,15 @@ class PDFOutline {
     this.outlineData = {};
 
     if (dest !== null) {
-      this.outlineData.Dest = [dest.dictionary, 'Fit'];
+      this.outlineData['Dest'] = [dest.dictionary, 'Fit'];
     }
 
     if (parent !== null) {
-      this.outlineData.Parent = parent;
+      this.outlineData['Parent'] = parent;
     }
 
     if (title !== null) {
-      this.outlineData.Title = new String(title);
+      this.outlineData['Title'] = new String(title);
     }
 
     this.dictionary = this.document.ref(this.outlineData);
@@ -39,8 +39,8 @@ class PDFOutline {
         this.outlineData.Count = this.children.length;
       }
 
-      const first = this.children[0];
-      const last = this.children[this.children.length - 1];
+      const first = this.children[0],
+        last = this.children[this.children.length - 1];
       this.outlineData.First = first.dictionary;
       this.outlineData.Last = last.dictionary;
 

packages/pdfkit/src/page.js

@@ -1,8 +1,13 @@
+/*
+PDFPage - represents a single page in the PDF document
+By Devon Govett
+*/
+
 const DEFAULT_MARGINS = {
-  top: 0,
-  left: 0,
-  bottom: 0,
-  right: 0
+  top: 72,
+  left: 72,
+  bottom: 72,
+  right: 72
 };
 
 const SIZES = {
@@ -64,7 +69,20 @@ class PDFPage {
     this.size = options.size || 'letter';
     this.layout = options.layout || 'portrait';
     this.userUnit = options.userUnit || 1.0;
-    this.margins = DEFAULT_MARGINS;
+
+    // process margins
+    if (typeof options.margin === 'number') {
+      this.margins = {
+        top: options.margin,
+        left: options.margin,
+        bottom: options.margin,
+        right: options.margin
+      };
+
+      // default to 1 inch margins
+    } else {
+      this.margins = options.margins || DEFAULT_MARGINS;
+    }
 
     // calculate page dimensions
     const dimensions = Array.isArray(this.size)
@@ -89,6 +107,8 @@ class PDFPage {
       Resources: this.resources,
       UserUnit: this.userUnit
     });
+
+    this.markings = [];
   }
 
   // Lazily create these objects
@@ -130,7 +150,7 @@ class PDFPage {
   }
 
   maxY() {
-    return this.height;
+    return this.height - this.margins.bottom;
   }
 
   write(chunk) {

packages/pdfkit/src/pattern.js

@@ -1,5 +1,3 @@
-/* eslint-disable operator-assignment */
-
 /*
 PDF tiling pattern support. Uncolored only.
  */

packages/pdfkit/src/tree.js

@@ -27,13 +27,10 @@ class PDFTree {
 
     const out = ['<<'];
     if (this.limits && sortedKeys.length > 1) {
-      const first = sortedKeys[0];
-      const last = sortedKeys[sortedKeys.length - 1];
+      const first = sortedKeys[0],
+        last = sortedKeys[sortedKeys.length - 1];
       out.push(
-        `  /Limits ${PDFObject.convert([
-          this._dataForKey(first),
-          this._dataForKey(last)
-        ])}`
+        `  /Limits ${PDFObject.convert([this._dataForKey(first), this._dataForKey(last)])}`
       );
     }
     out.push(`  /${this._keysName()} [`);
@@ -49,15 +46,15 @@ class PDFTree {
     return out.join('\n');
   }
 
-  _compareKeys() {
+  _compareKeys(/*a, b*/) {
     throw new Error('Must be implemented by subclasses');
   }
 
   _keysName() {
     throw new Error('Must be implemented by subclasses');
   }
 
-  _dataForKey() {
+  _dataForKey(/*k*/) {
     throw new Error('Must be implemented by subclasses');
   }
 }

packages/stylesheet/tests/expand.test.js

@@ -22,7 +22,7 @@ describe('stylesheet expand', () => {
         { marginBottom: '1 2 3' },
         { marginHorizontal: '1 2 3' },
         { margin: '1 2 3 4 5' },
-        { margin: () => console.log('function') },
+        { margin: () => {} },
       ];
       const expanded = {};
 
@@ -159,7 +159,7 @@ describe('stylesheet expand', () => {
         { paddingBottom: '1 2 3' },
         { paddingHorizontal: '1 2 3' },
         { padding: '1 2 3 4 5' },
-        { padding: () => console.log('function') },
+        { padding: () => {} },
       ];
       const expanded = {};