Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting - breaking changes to internal API to prepare #2148

Merged
merged 14 commits into from
Oct 17, 2024
Merged

Linting - breaking changes to internal API to prepare #2148

merged 14 commits into from
Oct 17, 2024

Commits on May 29, 2024

  1. Remove crufty and internally-unused methods from Formatter.

    @nedtwigg
    nedtwigg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    48e744d View commit details
    Browse the repository at this point in the history

  2. Moved PaddedCell.DirtyState to its own top-level class with new met… 

    …hods.
    @nedtwigg
    nedtwigg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5843830 View commit details
    Browse the repository at this point in the history

  3. Removed rootDir property Formatter and its builder because it was… 

    … only used to annnotate errors, which will now done by the lint phase.
    @nedtwigg
    nedtwigg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    856ab9f View commit details
    Browse the repository at this point in the history

  4. Mark the tests which are broken as part of the lint refactor.

    @nedtwigg
    nedtwigg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    b7f559a View commit details
    Browse the repository at this point in the history

  5. Remove the name property from Formatter, and route it in a different … 

    …way.
    @nedtwigg
    nedtwigg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7bd9c59 View commit details
    Browse the repository at this point in the history

  6. Remove the FormatExceptionPolicy from the Formatter because it wi… 

    …ll become part of linting.
    @nedtwigg
    nedtwigg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c6cfb6d View commit details
    Browse the repository at this point in the history

  7. And now the tests that do and don't work have shuffled once again.

    @nedtwigg
    nedtwigg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    baf0f11 View commit details
    Browse the repository at this point in the history

  8. Reduce the size of the diff.

    @nedtwigg
    nedtwigg committed May 29, 2024
    Configuration menu
    Copy the full SHA
    9347888 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. No reason for DirtyState.Calculation to be public API.

    @nedtwigg
    nedtwigg committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5f159a0 View commit details
    Browse the repository at this point in the history

  2. In fact there wasn't any reason for the DirtyState.Calculation class … 

    …to exist at all.
    @nedtwigg
    nedtwigg committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    baea8c9 View commit details
    Browse the repository at this point in the history

  3. Update contributor docs a bit.

    @nedtwigg
    nedtwigg committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    4f5bf51 View commit details
    Browse the repository at this point in the history

  4. Update changelog.

    @nedtwigg
    nedtwigg committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    33444a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into feat/prepare-for-lint-take-2

    @nedtwigg
    nedtwigg committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e1a9acb View commit details
    Browse the repository at this point in the history

  2. spotlessApply

    @nedtwigg
    nedtwigg committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5822660 View commit details
    Browse the repository at this point in the history