Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote build cache #2298

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Fix remote build cache #2298

merged 8 commits into from
Oct 15, 2024

Conversation

nedtwigg
Copy link
Member

This looks awful, but I hate to take 7.0 out of beta unless it's better than the 6.0 line, and I hate to break remote build cache (which is a beautiful design) just to satisfy configuration cache (which I think has some mistakes #987).

But this workaround isn't soooo big, it doesn't affect end users or step authors, and it makes the giant rewrite slightly more worth it.

@nedtwigg
Copy link
Member Author

@Goooler @jbduncan as soon as this passes CI I plan to release this as another beta, so that we can get more miles on it before getting out of this awful never-ending beta phase. Even if it's already merged and released I would still be interested in your feedback if you have any time to take a look.

@jbduncan
Copy link
Member

jbduncan commented Oct 15, 2024

@Goooler @jbduncan as soon as this passes CI I plan to release this as another beta, so that we can get more miles on it before getting out of this awful never-ending beta phase. Even if it's already merged and released I would still be interested in your feedback if you have any time to take a look.

Great! I'm a bit busy with IRL things this week, but I should have time this weekend to have a look. If I don't get back to you for whatever reason, feel free to ping me again and to release things anyway. :)

@nedtwigg nedtwigg merged commit 2ec663d into main Oct 15, 2024
28 checks passed
@nedtwigg nedtwigg deleted the feat/fix-caching branch October 15, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants