Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max clock skew #189

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Add max clock skew #189

merged 4 commits into from
Oct 10, 2024

Conversation

jameseaster
Copy link
Contributor

@jameseaster jameseaster commented Oct 10, 2024

Resolves #183


What kind of change does this PR introduce?

  • Feature update

What is the current behavior?

  • Clock skew is not taken into consideration

What is the new behavior?

  • Clock skew is considered in the time comparisons

Does this PR introduce a breaking change?

  • No

How has this been tested?

  • Currently, not tested as a package. I have tested the helper function compareTime locally with different values from example credentials. However, I have not been able to create the original bug that requires the maxClockSkew. More testing from other reviewers is needed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (545a4eb) to head (04639b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   90.44%   90.86%   +0.42%     
==========================================
  Files           5        5              
  Lines        1057     1106      +49     
==========================================
+ Hits          956     1005      +49     
  Misses        101      101              
Files with missing lines Coverage Δ
lib/helpers.js 94.21% <100.00%> (+1.01%) ⬆️
lib/index.js 91.01% <100.00%> (+0.32%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545a4eb...04639b6. Read the comment docs.

@dlongley dlongley merged commit f166681 into main Oct 10, 2024
5 checks passed
@dlongley dlongley deleted the add-maxClockSkew branch October 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement max clock skew (and default to 5 minutes) for issuance data / valid from date checks
3 participants