Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add babel-jest #532

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Add babel-jest #532

merged 3 commits into from
Dec 29, 2023

Conversation

curtvict
Copy link
Contributor

Closes #531

@curtvict curtvict requested a review from dilanx as a code owner December 11, 2023 19:04
dilanx
dilanx requested changes Dec 12, 2023
View reviewed changes
Copy link
Owner

@dilanx dilanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This change would need to be made in packages/craco/package.json instead but once done I can include this fix in the upcoming update.

@curtvict curtvict requested a review from dilanx December 12, 2023 17:07
@curtvict
Copy link
Contributor Author

Thanks for the guidance @dilanx. This should be the right spot now?

@curtvict curtvict mentioned this pull request Dec 14, 2023
Closed
@dilanx
Copy link
Owner

dilanx commented Dec 29, 2023 •
edited
Loading

Yup, looks good.

@dilanx dilanx merged commit 56840ce into dilanx:main Dec 29, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilanx dilanx dilanx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depend on babel-jest
2 participants
@curtvict @dilanx