Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Swift 5.0 #84

Open
wants to merge 2 commits into
base: new
Choose a base branch
from
Open

Convert to Swift 5.0 #84

wants to merge 2 commits into from

Conversation

InstaRobot
Copy link

Convert to new swift version and fix all warnings for deprecations and namespaces

@InstaRobot
Copy link
Author

That's all!

davidthorn
davidthorn approved these changes Apr 29, 2019
View reviewed changes
Copy link

@davidthorn davidthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cloned, built and ran it, all seems to be fine.

@pableiros
Copy link

This is the only Swift 5 pull request that doesn't have any warning at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidthorn davidthorn davidthorn approved these changes

@pableiros pableiros pableiros approved these changes

@iceman201 iceman201 iceman201 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InstaRobot @pableiros @iceman201 @davidthorn