Performance improvements #639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This likely means we will select the last FragmentSelectionSet with the name we're looking for instead of the first one, but I believe there shouldn't be collisions here anyway.
This unfortunately requires using List.reverse to keep the order which is slightly less performant than List.foldr. This will likely be a bit slower in the happy path, but faster in the unhappy path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a go through the codebase, and found a bunch of performance optimizations that could be applied.
(The only one with a perf trade-off is I think the last one, let me know if I should keep or remove it)
Also upgrades
elm-reviewand addsSimplifyandNoPrematureLetComputation, which found a few issues.I wish you a happy reviewing of an unrequested large PR 😛