Use a reserved "Default" layer for memberships in InteractionGroups
#706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le bit for memberships
Vrixyz
reviewed
Aug 2, 2024
src/geometry/interaction_groups.rs
Outdated
Comment on lines
86
to
84
| /// The default group. | ||
| const DEFAULT = 1 << 0; | ||
| /// The group n°1. | ||
| const GROUP_1 = 1 << 0; |
There was a problem hiding this comment.
Not sure I agree on shifting those groups though:
- it makes a tedious migrations for users
- javascript bindings will have to adapt (not hard, but tedious/error prone again)
the naming becomes a bit inconsistent, I would prefer DEFAULT and GROUP_1 being the same, or straight up removing DEFAULT, and add that's the default as a comment.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default is to being a member of all groups with a filter/interaction with everything.
I believe this is a bit backwards and makes special interactions between groups harder to understand/deal with without flipping all of your logic to be a "non-membership" or by modifying the interaction groups of every object in your simulation.
This is more in line with what Box2d (one membership, all filter) and Godot (one membership, one filter) do currently,
however there are counterexamples like Unity (all membership, all filter) and the current default.Unity is actually one membership/all filter as well since they do not allow multiple groups to be selected, however they allow configuring the default interactions/filters.There is also an argument of all filter vs one filter as the default, but I do not believe it matters as much as the membership.