Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an interaction group to specify fluid/boundary interactions #62

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Add an interaction group to specify fluid/boundary interactions #62

merged 4 commits into from
Nov 15, 2024

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Oct 17, 2024 •
edited
Loading

TODO:

  • This PR doesn´t add the capacity to add interaction group between fluids (yet? It seems to be possible but didn´t look much into it yet.)
  • check benchmarks

@Vrixyz Vrixyz requested a review from sebcrozet November 8, 2024 09:02
Vrixyz
Vrixyz commented Nov 8, 2024
View reviewed changes
examples2d/layers2.rs Outdated Show resolved Hide resolved
sebcrozet
sebcrozet approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

src/geometry/contacts.rs
.test(bj.fluid_interaction)
{
continue;
}
boundaries[fluid_j].positions[particle_j]
} else {
fluids[fluid_j].positions[particle_j]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a good chance that adding support for groups between two fluids is only a matter of adding a check in this branch too.

@Vrixyz Vrixyz merged commit 7e598e8 into dimforge:master Nov 15, 2024
23 checks passed
@Ughuuu
Copy link

Ughuuu commented Nov 16, 2024

So this adds just between fluid/boundary? Still, thanks for this PR.

@Vrixyz
Copy link
Contributor Author

Vrixyz commented Nov 16, 2024

So this adds just between fluid/boundary? Still, thanks for this PR.

Yes ; fluid / fluid layers will be studied in a follow up PR 🤞

@Vrixyz Vrixyz mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebcrozet sebcrozet sebcrozet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering liquids with rapier rigidbodies based on masks/layers
3 participants
@Vrixyz @Ughuuu @sebcrozet