Fix wuxiaworld.com #2204
Merged
Fix wuxiaworld.com #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this update include: * update for Bearer that in dipu-bd#1360, which will make the Bearer login work in both scraper and Browser method. * username/email and password can be used to login now. * the script will wait for "Time Until Free Chapter" msg until disappear and chapter will fully loaded PS-1: if in your account setting you enabled Auto-unlock, and script used browser method you will unlock all chapter you marked in range PS-2:dont put locked chapter in scraping range if chapter auto-unlock is disable as that will hang/enter the script into infinite loop of waiting
dipu-bd
reviewed
Dec 4, 2023
| #self._restore_cookies() | ||
| #logger.debug("cookies: Email(%s)", str(self.cookies)) | ||
| #logger.debug("headers: Email(%s)", str(self.headers)) | ||
| try: |
There was a problem hiding this comment.
please remove the commented out codes. this helps the codebase to stay clean.
There was a problem hiding this comment.
sure
but what about headless? should i turn it on?
There was a problem hiding this comment.
no need. it will be automatically turned off for environments with no display
dipu-bd
approved these changes
Dec 12, 2023
|
The changes looks good, but there are some minor issues with linting. Check here: https://github.com/dipu-bd/lightnovel-crawler/actions/runs/7156781251/job/19575165040?pr=2204 |
|
will look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this update include:
PS-1: if in your account setting you enabled Auto-unlock, and script used browser method you will unlock all chapter you marked in range.
PS-2:dont put locked chapter in scraping range if chapter auto-unlock is disable as that will hang/enter the script into infinite loop of waitingPS-2:its not recommended to put locked chapter in scraping range if chapter auto-unlock is disable as that will make script to wait longer to see if the chapter will unlocked or not (like 10-20sec for each locked chapter)