add faqwiki.py as english source #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CryZFix
reviewed
Jan 26, 2024
CryZFix
reviewed
Jan 26, 2024
|
As you've assigned yourself as a reviewer I'm not sure if I should've resolved the discussions myself after the newest commit, @CryZFix is it alright like this or should I usually wait for the reviewer to resolve discussions instead after my ammending commits &/ comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2233
Adds a new source as requested in the aforementioned issue.
I used #2232 as my template, though I was able to get a lot more consistent metadata out of this one compared to the previous one.
Tested manually like so
python -m lncrawl -s https://faqwiki.us/the-100th-regression-of-the-max-level-player/and it worked as intended.Also tested the search works as well:
python -m lncrawl -q mage --sources https://faqwiki.us/though it doesn't remove the suffix there, but when actually choosing and downloading one it does.