WIP: ES6 and testing framework #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2018 15:13
This change was made to be more aligned with ES6. Note that we use the unoffical `babel-plugin-dynamic-import-node` plugin to transpile the dynamic import to a require for mocha-purposes. This is something that would normally be done by a tool like webpack.
|
@bkaptijn This wasn't actually finished yet, so there are a lot fewer tests now 😅 |
|
I know ;-P, but the old ones arent that great (atomic for instance). Just look at the old ones and reimplement the tests. I'm going to do the same for discipl-core-memory etc.. will wait on you saying you are finished before merging from now on. |
This was referenced Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out the first part of #11, which immediately implied that the tests would break (rewire does not support es6 modules), so I also started on the test framework #12
I'm actually not too sure about whether we want to use karma for testing at library level, nor if we want to be doing webpack at library level. Input here is appreciated.
This PR does some initial setup for using mocha, but is not finished.
TODO: