Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: smart date support for AI helper #1044

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

FEATURE: smart date support for AI helper #1044

wants to merge 5 commits into from

Conversation

SamSaffron
Copy link
Member

This feature allows conversion of human typed in dates and times
to smart "Discourse" timezone friendly dates.

This feature allows conversion of human typed in dates and times
to smart "Discourse" timezone friendly dates.
Copy link
Member

@keegangeorge keegangeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! I'm excited for this, it's a nifty little feature.

Can we add system specs for this?

lib/ai_helper/assistant.rb Outdated Show resolved Hide resolved
cp.messages = {
insts: <<~TEXT,
You are a date and time formatter for Discourse posts. Convert natural language time references into date placeholders.
Do not modify any markdown, code blocks, or existing date formats.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add specs that checks to ensure it doesn't modify any of these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to be pretty impossible, the llm is in charge of this.

@SamSaffron
Copy link
Member Author

system spec feels expensive for this especially since helper is already covered... added a bit more internal coverage though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants