DEV: Move semantic search out of connector to component #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegangeorge
approved these changes
Nov 12, 2024
| import I18n from "I18n"; | ||
| import AiIndicatorWave from "./ai-indicator-wave"; | ||
|
|
||
| export default class AiFullPageSemanticSearch extends Component { |
There was a problem hiding this comment.
We're updating the name of Semantic Search -> AI search (see /t/141433), so maybe we can change this while we're at it to:
Suggested change
| export default class AiFullPageSemanticSearch extends Component { | |
| export default class AiFullPageSearch extends Component { |
| import icon from "discourse-common/helpers/d-icon"; | ||
| import I18n from "I18n"; | ||
| import AiIndicatorWave from "../../components/ai-indicator-wave"; | ||
| import AIFullPageSemanticSearch from "discourse/plugins/discourse-ai/discourse/components/ai-full-page-semantic-search"; |
There was a problem hiding this comment.
Based on my previous comment, and maybe we can use relative path as it's more concise?
Suggested change
| import AIFullPageSemanticSearch from "discourse/plugins/discourse-ai/discourse/components/ai-full-page-semantic-search"; | |
| import AiFullPageSearch from "../../components/ai-full-page-search"; |
| import icon from "discourse-common/helpers/d-icon"; | ||
| import I18n from "I18n"; | ||
| import AiIndicatorWave from "../../components/ai-indicator-wave"; | ||
| import AIFullPageSemanticSearch from "discourse/plugins/discourse-ai/discourse/components/ai-full-page-semantic-search"; | ||
|
|
||
| export default class SemanticSearch extends Component { |
There was a problem hiding this comment.
Suggested change
| export default class SemanticSearch extends Component { | |
| export default class AiSearch extends Component { |
| </div> | ||
| </div> | ||
| {{/if}} | ||
| <AIFullPageSemanticSearch @outletArgs={{@outletArgs}} /> |
There was a problem hiding this comment.
Suggested change
| <AIFullPageSemanticSearch @outletArgs={{@outletArgs}} /> | |
| <AiFullPageSearch @outletArgs={{@outletArgs}} /> |
keegangeorge
requested changes
Nov 12, 2024
|
@markvanlan where are we on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the semantic search component to be rendered by another plugin, rather than being defined in the connector, which limits it's usage.