FIX: avoid deprecated replace_flag API (#57)

`replace_flag` API will be deprecated. Therefore `malicious_file` score type must be entered into the database. In addition, migration is fixing IDs.

.discourse-compatibility

@@ -1,2 +1,3 @@
+< 3.3.0.beta3-dev: d83344a719c21615690c620d2ddb98b5b1ca3cd8
 < 3.3.0.beta1-dev: f0792d8bd3a275330045175cb064d5524f47dc11
 3.1.999: 50177ed0e00b8e2c744267b727fb05784f0d4776

db/migrate/20240527061406_add_malicious_file_score_type.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+class AddMaliciousFileScoreType < ActiveRecord::Migration[7.0]
+  def change
+    result = DB.query <<~SQL
+      SELECT MAX(position) FROM flags
+    SQL
+
+    position = result.last&.max
+
+    result = DB.query <<~SQL
+      INSERT INTO flags(name, name_key, applies_to, score_type, position, created_at, updated_at)
+      VALUES ('Malicious File', 'malicious_file', '{}', true, #{position.to_i + 1}, NOW(), NOW())
+      RETURNING flags.id
+    SQL
+
+    new_score_id = result.last&.id
+
+    DB.exec <<~SQL
+      UPDATE reviewable_scores rs1
+      SET reviewable_score_type = #{new_score_id}
+      FROM reviewable_scores rs2
+      LEFT JOIN reviewables ON reviewables.id = rs2.reviewable_id
+      WHERE rs2.reason = 'malicious_file'
+      AND reviewables.type = 'ReviewableUpload'
+      AND rs1.id = rs2.id
+    SQL
+  end
+end

plugin.rb

@@ -33,8 +33,6 @@
 
   register_reviewable_type ReviewableUpload
 
-  replace_flags(settings: PostActionType.flag_settings, score_type_names: %i[malicious_file])
-
   add_to_serializer(
     :site,
     :clamav_unreacheable,