-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http proxy #501
Http proxy #501
Conversation
Signed-off-by: Edit Koselak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The long line in this code block will require horizontal scrolling in HTML output, and be truncated in PDF output.
We may want to consider inserting \
line continuation characters in the code block to ensure the example remains readable, but I'm not sure if those can be encoded within the ANT_OPTS
value in a way that works on all platforms. (Perhaps @raducoravu knows?) 🤔
I'm also thinking we might want to move this information to a dedicated topic, perhaps in the Troubleshooting section, where other |
Co-authored-by: Roger Sheen <[email protected]> Signed-off-by: EditKoselak <[email protected]>
Signed-off-by: Edit Koselak <[email protected]>
Thank you for the suggestions! We tested the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of "for installing and downloading content" I would say "for installing plugins from the configured registry or processing remote referenced resources"
This part "provide the proxy configuration via the ANT_OPTS environment variable", on various operating systems there are various ways to set env variables, on Windows I would use in a Command Prompt window "set envName=envValue" and then I would call "dita..." on a separate line. On Mac OS I would use in the Terminal "export envName=envValue". I think this would be the same for Linux.
Also the "dita install " part should probably be on a separate line in the codeblock.
Hello @infotexture, @raducoravu, |
Signed-off-by: EditKoselak <[email protected]>
@EditKoselak Yes, I think that's the right approach. |
Signed-off-by: Edit Koselak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇 Thanks for your input here, looks pretty good now.
I implemented the feedback from @raducoravu in #501 (review) and prepared a few tweaks, but I'm not able to push additional commits to your fork as part of this PR, so I'll merge this as is now, and submit those separately.
Per #501 (review) Signed-off-by: Roger Sheen <[email protected]>
Description
Explain how to set HTTP proxy for the "dita" command
Motivation and Context
Fixes #189
How Has This Been Tested?
The documentation was compiled locally using the
gradlew -PditaHome=/path/to/dita-ot
commandType of Changes
Documentation
Documentation and Compatibility
No additional documentation needed.
Checklist