Use latest version in release & dev docs workflows #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Sheen <[email protected]>
infotexture
commented
Oct 9, 2023
| @@ -6,7 +6,7 @@ inputs: | |||
| default: 'master' | |||
| DITA_OT_VERSION: | |||
| description: 'DITA-OT version used for rendering' | |||
| default: '4.0.1' | |||
| default: '4.1.2' | |||
There was a problem hiding this comment.
@jelovirt Could we use a variable here?
There was a problem hiding this comment.
That's the default value for the variable. So in a way it's already a variable.
infotexture
commented
Oct 9, 2023
| @@ -19,7 +19,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| env: | |||
| WEBSITE_PLUGIN_BRANCH: 'master' | |||
| DITA_OT_VERSION: '4.0.1' | |||
| DITA_OT_VERSION: '4.1.2' | |||
|
This PR is replaced by #512 that was generated by CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelovirt Our docs CI workflows have been stuck on a hard-coded version
4.0.1for a while now.This PR manually bumps them both to the latest version
4.1.2, but we should explore options for automating or parameterizing this to always use the latest tagged version from themasterbranch.Any ideas?