Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove image with --rm when running Docker #521

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Remove image with --rm when running Docker #521

merged 1 commit into from
Dec 21, 2023

Conversation

jelovirt
Copy link
Member

@jelovirt jelovirt commented Dec 21, 2023 •
edited by infotexture
Loading

Description

Change Docker usage to use --rm option and remove redundant -it per #519.

Followup to #520.

Motivation and Context

For most users, --rm is a better default.

Type of Changes

  • New feature (non-breaking change which adds functionality)

@jelovirt jelovirt added the enhancement Changes to an existing topic or feature label Dec 21, 2023
@infotexture infotexture changed the title Remove use --rm when running docker image Remove image with --rm when running Docker Dec 21, 2023
infotexture
infotexture approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@infotexture infotexture merged commit 08b12f8 into develop Dec 21, 2023
5 checks passed
@infotexture infotexture deleted the feature/519-small-proposed-changes-for-docker-image-creation2 branch December 30, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infotexture infotexture infotexture approved these changes

Assignees
No one assigned
Labels
enhancement Changes to an existing topic or feature
Projects
No open projects
4.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelovirt @infotexture