Improvement/component renderer #234
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinehell
requested changes
Sep 18, 2023
| @@ -103,6 +103,7 @@ Then('I expect {string} to be at position {int},{int}', (templateSelector, x, y) | |||
| expect(Math.trunc(parseInt(element.attr('x')))).eq(x); | |||
| expect(Math.trunc(parseInt(element.attr('y')))).eq(y); | |||
| }); | |||
|
|
|||
| document.querySelector('#root').innerHTML = ''; | ||
| plugin.draw('root', readOnly.value); | ||
| document.querySelector('#view-port').innerHTML = ''; | ||
| plugin.draw(); |
There was a problem hiding this comment.
lack of consistency - no parameters here (vs line 85) ?
| plugin.draw('root'); | ||
| updateComponentsIds(); | ||
| plugin.initDrawingContext(); | ||
| plugin.draw(); |
There was a problem hiding this comment.
same - lack of consistency - no parameters here (vs line 95) ?
Comment on lines
+9
to
+31
| <svg class="model" overflow="visible" fill="#474262" width="230" height="50" | ||
| {% if hasX and hasY %} | ||
| x="{{ drawOption.x }}" y="{{ drawOption.y }}" | ||
| {% else %} | ||
| x="0" y="0" | ||
| {% endif %} | ||
| > | ||
| <rect class="background" width="100%" height="100%" rx="6" /> | ||
|
|
||
| <svg x="6" y="6" width="38" height="38"> | ||
| <rect fill="#9691B1" width="100%" height="100%" rx="5"/> | ||
| <g class="type-icon" fill="#474262" transform="translate(3 3)">{{ icon | safe }}</g> | ||
| </svg> | ||
|
|
||
| {% if hasError %} | ||
| <g class="component-error"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" | ||
| width="15" height="15" | ||
| x=200 y="10" | ||
| fill="yellow" | ||
| viewBox="0 0 512 512"> | ||
| <path d="M256 512c141.4 0 256-114.6 256-256S397.4 0 256 0S0 114.6 0 256S114.6 512 256 512zm0-384c13.3 0 24 10.7 24 24V264c0 13.3-10.7 24-24 24s-24-10.7-24-24V152c0-13.3 10.7-24 24-24zm32 224c0 17.7-14.3 32-32 32s-32-14.3-32-32s14.3-32 32-32s32 14.3 32 32z"/> | ||
| </svg> | ||
| <g class="error-icon"> | ||
| <svg width="15" height="15" x="200" y="10" fill="yellow" viewBox="0 0 512 512"> | ||
| <path d="M256 512c141.4 0 256-114.6 256-256S397.4 0 256 0S0 114.6 0 256S114.6 512 | ||
| 256 512zm0-384c13.3 0 24 10.7 24 24V264c0 13.3-10.7 24-24 | ||
| 24s-24-10.7-24-24V152c0-13.3 10.7-24 24-24zm32 224c0 17.7-14.3 32-32 | ||
| 32s-32-14.3-32-32s14.3-32 32-32s32 14.3 32 32z" | ||
| /> | ||
| </svg> |
There was a problem hiding this comment.
Maybe I need explaination - what are theses changes and why need them ?
| @@ -23,6 +23,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - `getDefinedAttributesByType` will now return nested attributes inside object, fix [this bug](https://github.com/ditrit/leto-modelizer-plugin-core/issues/203). | |||
|
|
|||
| - Add `arrangeComponentsPosition` method in `DefaultDrawer` and `DefaultPlugin` | |||
There was a problem hiding this comment.
I dont see the addition of arrangeComponentsPosition method in DefaultDrawer and DefaultPlugin? The function already existed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Don't forget to modify the changelog.md before merging this branch.