[DIT-6379] Fix terminal hanging when Ctrl + C pressed during pull and token prompt
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjgard
commented
Mar 22, 2024
| @@ -1,4 +1,4 @@ | |||
| export function quit(message: string | null, exitCode = 2) { | |||
| if (message) console.log(`\n${message}\n`); | |||
| process.exitCode = exitCode; | |||
There was a problem hiding this comment.
This was incorrect - setting the exit code ensured that when the process exited of other means, it would have the specified status, but the intent of the quit() function in all instances of usage is to immediately terminate the running process.
jaerod95
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an issue where the CLI would become unresponsive but fail to fully exit when the user attempted to use Ctrl + C to bail out of the process.
Context
https://linear.app/dittowords/issue/DIT-6379/fix-cli-hanging-when-ctrlc-out-of-token-collection-prompt
Test Plan
~/.config/dittoyarn start pull