Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix/use-filesets #16

Merged
merged 4 commits into from
Feb 14, 2024
Merged

nix/use-filesets #16

merged 4 commits into from
Feb 14, 2024

Conversation

djacu
Copy link
Owner

@djacu djacu commented Feb 13, 2024

Replaced path or strings paths with filesets.

Now the critical derivations (the dependency environment, the lessons, and the site) are not tied to the entire repository. The derivation closure is scoped to only what is necessary and should save on build times and creating unnecessary derivations if something unrelated changes (e.g. in the flake file).

Copy link

github-actions bot commented Feb 13, 2024

@github-actions github-actions bot temporarily deployed to pull request February 13, 2024 20:50 Inactive
Copy link
Contributor

@YorikSar YorikSar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need unions if it's just one path.

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request February 13, 2024 21:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 14, 2024 00:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 14, 2024 00:12 Inactive
@djacu djacu merged commit d8fa044 into main Feb 14, 2024
2 checks passed
@djacu djacu deleted the nix/use-filesets branch February 14, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants