meta/refactor document lessons library #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
djacu
commented
Feb 10, 2024
djacu
commented
- Add doc-comment for getFileExtension.
- Rename findStrings to multilineMatch and add doc-comment.
- Create makeFencedCodeBlock expression.
- Refactor createLessonMetadata to accept an attrset for high level arguments.
- Refactor createLessonMetadata to use more of the new functions.
- Refactor createLessonMetadata by moving keys that don't need to be in the output to the let/in block.
- Refactor filesToSubstitute to append the parent path to the file name.
- Refactor textToSubstitute to use the new makeFencedCodeBlock expression.
- Add doc-comment for makeFencedCodeBlock.
- Add comments for all the higher level functions that create metadata or building markdown documentation.
- Add doc-comment for getLessons.
Rename findStrings to multilineMatch and add doc-comment. Create makeFencedCodeBlock expression. Refactor createLessonMetadata to accept an attrset for high level arguments. Refactor createLessonMetadata to use more of the new functions. Refactor createLessonMetadata by moving keys that don't need to be in the output to the let/in block. Refactor filesToSubstitute to append the parent path to the file name. Refactor textToSubstitute to use the new makeFencedCodeBlock expression.
…or building markdown documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.