Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure GitHub actions to publish packages #418

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

acdha
Copy link
Collaborator

@acdha acdha commented Aug 15, 2023

This is a first pass enabling the PyPI trusted publisher workflow

@acdha acdha force-pushed the use-github-actions-to-publish-packages branch from a6c2cbb to 414c1c3 Compare August 15, 2023 14:46
@acdha
Copy link
Collaborator Author

acdha commented Aug 15, 2023

@cclauss I wanted to make it easy for you to run releases for these projects & figured I'd start with pysolr since it's simpler than Haystack. Beyond the obvious “does this actually work” check, one thought I had is reviewing the branching model. I'd been meaning to get away from “master” for a while and was wondering whether we should have “development” and “release” to make it more clear which one tracks the releases you get on PyPI which is more work in progress.

@acdha acdha requested a review from cclauss August 15, 2023 14:50
@acdha acdha force-pushed the use-github-actions-to-publish-packages branch from 414c1c3 to 1acf263 Compare August 15, 2023 14:55
@cclauss
Copy link
Contributor

cclauss commented Aug 15, 2023

I think it is better to keep a default master/main branch that is up-to-date. Then make release branches (named like v3.9.0) for each release. This way when folks want to make contributions, they make them to the default branch but if other folks want the code for a particular branch, it is also available to them. Thoughts?

This reverts commit 798b106 so releases
will be the only event which triggers a build.
@acdha
Copy link
Collaborator Author

acdha commented Aug 15, 2023

I think it is better to keep a default master/main branch that is up-to-date. Then make release branches (named like v3.9.0) for each release. This way when folks want to make contributions, they make them to the default branch but if other folks want the code for a particular branch, it is also available to them. Thoughts?

I'd probably only create a branch if we actually were working on something big and upgrade-blocking, such as adding async support or something like that. In general we've tended to encourage people to fix problems by installing the latest version so maybe we should:

  1. Rename “master” to “release”
  2. Update the readme to note that changes against an old release which can't be made against the current release branch should use a versioned branch along the lines of v3.x, etc.

@cclauss
Copy link
Contributor

cclauss commented Aug 15, 2023

"Release" is not a self-documenting branch name in my book but let's go for it.

@cclauss cclauss enabled auto-merge (squash) August 15, 2023 20:14
@cclauss cclauss merged commit a7fdd19 into master Aug 15, 2023
8 checks passed
@cclauss cclauss deleted the use-github-actions-to-publish-packages branch August 15, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants